recttty: nits #2694
Merged
recttty: nits #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
previously approved these changes
Dec 1, 2020
Saves us a few lines of code. Signed-off-by: Kir Kolyshkin <[email protected]>
It looks like we need to wait for the both copy goroutines to finish, not just the one that happen to finish first. Signed-off-by: Kir Kolyshkin <[email protected]>
Fixes the following errcheck linter warnings > contrib/cmd/recvtty/recvtty.go:115:10: Error return value of `io.Copy` is not checked (errcheck) > io.Copy(os.Stdout, c) > ^ > contrib/cmd/recvtty/recvtty.go:120:11: Error return value of `io.Copy` is not checked (errcheck) > io.Copy(c, os.Stdin) > ^ > contrib/cmd/recvtty/recvtty.go:175:11: Error return value of `io.Copy` is not checked (errcheck) > io.Copy(devnull, master) > ^ Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
recvtty-nits
branch
from
6506564
to
de80aae
Compare
|
Had to rebase to satisfy newly required CI checks, so we lost both LGTMs. No code changes though. |
AkihiroSuda
approved these changes
Dec 1, 2020
mrunalp
approved these changes
Dec 1, 2020
This was referenced Dec 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2627.
1. recvtty: use ioutil.Discard
2. recvtty: fix waiting for both goroutines
3. recvtty: fix errcheck linter warnings