s390x: fix big endian issue #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs cilium/ebpf#91 as well? |
|
yes, otherwise the ebpf library still generates the wrong position for src and dst registers on s390x. I'll check with @iii-i, what is blocking or the TODOs for that PR |
|
cilium/ebpf#91 seems merged. |
|
Was this closed by mistake? |
added 2 commits
May 8, 2020 07:31
Load the full 32 bits word and take the lower 16 bits, instead of reading just 16 bits. Same fix as containers/crun@07bae05 Signed-off-by: Alice Frosi <[email protected]>
The test cases need to take into account the assembly modifications.
The instruction:
LdXMemH dst: r2 src: r1 off: 0 imm: 0
has been replaced with:
LdXMemW dst: r2 src: r1 off: 0 imm: 0
And32Imm dst: r2 imm: 65535
Signed-off-by: Alice Frosi <[email protected]>
|
@AkihiroSuda sorry, I had some wrong setup in my git. |
|
LGTM |
Update ebpf to include PR cilium/ebpf#91. The update is needed to fix opencontainers#2316. Signed-off-by: Alice Frosi <[email protected]>
|
Merged with the PR #2389 |
|
LGTM |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a carry of #2350
This PR fixes a big endian issue and modify the tests accordingly.
The solution is based on the same fix as containers/crun@07bae05