ebpf: fix big endian issue for s390x #2350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alicefr can you please amend the commit message with what is being done? Somethhing like escription from containers/crun@07bae05 is good enough. |
|
Please update UT |
|
ping @alicefr |
Closed
|
@AkihiroSuda @kolyshkin sorry for the delay. I update the comment |
|
Please be aware that you need also this PR before fixing the ebpf issue cilium/ebpf#91 |
|
This PR is not working on x86. Need to figure out what's wrong |
|
I changed the assembly so also the test cases need to be modified accordingly |
|
I accidentally closed this PR and I cannot reopen it. Even if I add new commits. |
|
I can't reopen either, please open a new one? |
|
@AkihiroSuda sorry for the mess here the new PR #2381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as containers/crun@07bae05
This also needs cilium/ebpf#91
Signed-off-by: Alice Frosi [email protected]