-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-types: show relations between media types #55
Conversation
I don't think specs for It will likely go beyond that, and include several images 1, and |
@@ -58,3 +57,7 @@ oci-validate-json: validate.go | |||
oci-validate-examples: cmd/oci-validate-examples/main.go | |||
go build ./cmd/oci-validate-examples | |||
|
|||
%.dot.png: %.dot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like make patterns, but nothing is depending on the media-types.dot.png
target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks, also it doesn't appear in the generated doc, will fix.
@s-urbaniak serialization.rootfs and serialization.config are siblings of image.manifest. Otherwise I think this is helpful for folks and we should probably add language around it. |
7579a67
to
140980e
Compare
@s-urbaniak you have two copies checked in now. Can you remove the outdated one? |
Signed-off-by: Sergiusz Urbaniak <[email protected]>
@philips fixed, thanks! |
LGTM @vbatts thoughts? |
@s-urbaniak fixed my concerns. LGTM |
The Docker link landed in 7b39189 (media-types: show relations between media types, 2016-05-02, opencontainers#55), but we've had a descriptor definition locally since d49d055 (spec: describe descriptors and digests, 2016-06-01, opencontainers#111). Signed-off-by: W. Trevor King <[email protected]>
Please ignore this PR if you think it is not useful, it is mere manifestation of my notes and the relations between all the JSON files in this spec.
I am still unsure of the combined output format, see #54.