Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-types: show relations between media types #55

Merged
merged 1 commit into from
May 3, 2016

Conversation

s-urbaniak
Copy link
Collaborator

Please ignore this PR if you think it is not useful, it is mere manifestation of my notes and the relations between all the JSON files in this spec.

I am still unsure of the combined output format, see #54.

@wking
Copy link
Contributor

wking commented May 2, 2016

I don't think specs for
application/vnd.oci.image.serialization.config.v1+json have landed yet
(it seems to be based on discussion in #23), but I'd expect it will
include everything up through
application/vnd.oci.image.manifest.v1+json and possibly
application/vnd.oci.image.manifest.list.v1+json.

It will likely go beyond that, and include several images 1, and
possibly signatures asserting names for those images, but I don't
think there is a consensus yet on how that information will be
structured.

@@ -58,3 +57,7 @@ oci-validate-json: validate.go
oci-validate-examples: cmd/oci-validate-examples/main.go
go build ./cmd/oci-validate-examples

%.dot.png: %.dot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like make patterns, but nothing is depending on the media-types.dot.png target

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks, also it doesn't appear in the generated doc, will fix.

@philips
Copy link
Contributor

philips commented May 3, 2016

@s-urbaniak serialization.rootfs and serialization.config are siblings of image.manifest. Otherwise I think this is helpful for folks and we should probably add language around it.

@s-urbaniak s-urbaniak force-pushed the media-types branch 3 times, most recently from 7579a67 to 140980e Compare May 3, 2016 13:39
@philips
Copy link
Contributor

philips commented May 3, 2016

@s-urbaniak you have two copies checked in now. Can you remove the outdated one?

@s-urbaniak
Copy link
Collaborator Author

@philips fixed, thanks!

@philips
Copy link
Contributor

philips commented May 3, 2016

LGTM

@vbatts thoughts?

@vbatts
Copy link
Member

vbatts commented May 3, 2016

@s-urbaniak fixed my concerns. LGTM

@vbatts vbatts merged commit ab93b13 into opencontainers:master May 3, 2016
wking added a commit to wking/image-spec that referenced this pull request Sep 18, 2016
The Docker link landed in 7b39189 (media-types: show relations
between media types, 2016-05-02, opencontainers#55), but we've had a descriptor
definition locally since d49d055 (spec: describe descriptors and
digests, 2016-06-01, opencontainers#111).

Signed-off-by: W. Trevor King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants