Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-types: Replace Docker link with internal descriptor link #324

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

wking
Copy link
Contributor

@wking wking commented Sep 18, 2016

The Docker link landed in #55, but we've had a descriptor definition locally since #111.

The Docker link landed in 7b39189 (media-types: show relations
between media types, 2016-05-02, opencontainers#55), but we've had a descriptor
definition locally since d49d055 (spec: describe descriptors and
digests, 2016-06-01, opencontainers#111).

Signed-off-by: W. Trevor King <[email protected]>
@jonboulle
Copy link
Contributor

jonboulle commented Sep 18, 2016

LGTM

Approved with PullApprove

@wking
Copy link
Contributor Author

wking commented Sep 20, 2016

Oops, I accidentally bumped this branch and have since reset it to the original f4a7ea2. I'm not sure what that does with PullApprove LGTMs, but @jonboulle's earlier LGTM may no longer count.

@vbatts
Copy link
Member

vbatts commented Sep 20, 2016

LGTM

Approved with PullApprove

1 similar comment
@philips
Copy link
Contributor

philips commented Sep 21, 2016

LGTM

Approved with PullApprove

@philips philips merged commit eebd585 into opencontainers:master Sep 21, 2016
@wking wking deleted the descriptor-references branch September 21, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants