Run all examples for job windows_latest_cmake in CI
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fghoussen
reviewed
Jan 21, 2023
|
@FabienPean: just tried to push on top of you to see if we could also get MPI build/test... Bad idea! :( Reverting |
This reverts commit 569a558.
* Add flag `-fallow-invalid-boz` fixing false positive errors on comments * Replace `mpirun` by standard `mpiexec` * Fix working directory of tests for MPI binaries
|
The CI now also runs the MPI examples and the changelog has been updated. Changelog for #391 will come in a follow-up PR to make a small adjustment on the macro and its use |
FabienPean
changed the title
windows_latest_cmake in CIwindows_latest_cmake in CI
fghoussen
reviewed
Jan 25, 2023
|
@FabienPean: merci Fabien ! :) |
|
Avec plaisir :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binaries of examples were not able to find
libarpack.dlland failing, while tests were passing. The main difference in CMakeLists was setting the working directory for examples and not for tests. The binaries are probably linked without an absolute path for the library and searching the DLL in local folder. Changing the working directory in CMake changed the search local path where the DLL is absent.To fix using MPI examples on Windows, the following was necessary:
-fallow-invalid-bozfixing false positive errors on comments, e.g.mpirunby standardmpiexec