[CI] Windows job: run full test suite. #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juanjosegarciaripoll: what would be the needed minimal changes to fix this? (don't hesitate to push on top of this PR) |
|
I have to look at this again, because the canonical way of declaring tests seemed to interfere with your build configuration and use of global variables. Will get back once I find a solution. |
|
@juanjosegarciaripoll: did you had time to look at this? Would be nice to have minimal changes to run on windows. |
|
Fixed by #392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request purpose
Checking if db55a7f enables to run full test suite on windows.