Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding a description when using opt_in requirement level #392

Merged

Conversation

joaopgrassi
Copy link
Member

@joaopgrassi joaopgrassi commented Sep 30, 2024

I bumped into this while working on open-telemetry/semantic-conventions#474. I want to change a requirement level to opt_in and add a description to it, but I can't because the schema doesn't allow it.

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change!

@joaopgrassi joaopgrassi marked this pull request as ready for review October 1, 2024 08:08
@joaopgrassi joaopgrassi requested review from a team as code owners October 1, 2024 08:08
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema changes look great to me. Thanks for doing this!

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel lquerel merged commit 3d38b7f into open-telemetry:main Oct 1, 2024
21 checks passed
@joaopgrassi joaopgrassi deleted the opt-in-description branch October 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants