Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rpc and messaging body/payload size attributes from recommended to opt-in? #474

Open
trask opened this issue Oct 30, 2023 · 2 comments
Open

Change rpc and messaging body/payload size attributes from recommended to opt-in? #474

trask opened this issue Oct 30, 2023 · 2 comments
Assignees
@joaopgrassi
Labels
area:messaging area:rpc

Comments

@trask
Copy link
Member

trask commented Oct 30, 2023 •
edited
Loading

I guess we should then consider doing the same for messaging (messaging.message.body.size and messaging.message.envelope.size) and RPC (message.compressed_size and message.uncompressed_size)?

Originally posted by @pyohannes in #460 (comment)
@trask trask mentioned this issue Oct 30, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this to V1 - Stable Semantics in Spec: Messaging Semantics Oct 30, 2023
@pyohannes pyohannes mentioned this issue Jan 18, 2024
Closed
@pyohannes pyohannes moved this from V1 - Stable Semantics to Post-stability in Spec: Messaging Semantics Jan 18, 2024
@github-actions github-actions bot added the Stale label Feb 11, 2024
@joaopgrassi joaopgrassi removed the Stale label Feb 14, 2024
@joaopgrassi joaopgrassi self-assigned this Sep 30, 2024
@joaopgrassi
Copy link
Member

Going to work on the messaging side of this. But I bumped into a tooling limitation. It seems we can't have a description for the opt_in requirement level: open-telemetry/weaver#392

This was referenced Oct 1, 2024
Merged
Merged
@joaopgrassi
Copy link
Member

#1442 was merged, so I removed this from blocking Messaging stabilization. What is left is changing the RPC ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaopgrassi joaopgrassi

Labels
area:messaging area:rpc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trask @joaopgrassi @reyang