Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check group id, metric name, and group name uniqueness #382

Merged
merged 13 commits into from
Nov 22, 2024

feat(check_group): Use itertools unique for clarity.

13d5421
Select commit
Loading
Failed to load commit list.
Merged

Check group id, metric name, and group name uniqueness #382

feat(check_group): Use itertools unique for clarity.
13d5421
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2024 in 1s

73.0% (+0.4%) compared to cab3125

View this Pull Request on Codecov

73.0% (+0.4%) compared to cab3125

Details

Codecov Report

Attention: Patch coverage is 85.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.0%. Comparing base (cab3125) to head (13d5421).

Files with missing lines Patch % Lines
crates/weaver_diff/src/lib.rs 81.3% 11 Missing ⚠️
crates/weaver_resolver/src/registry.rs 95.2% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #382     +/-   ##
=======================================
+ Coverage   72.5%   73.0%   +0.4%     
=======================================
  Files         49      49             
  Lines       3635    3711     +76     
=======================================
+ Hits        2639    2710     +71     
- Misses       996    1001      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: