Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check group id, metric name, and group name uniqueness #382

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Sep 20, 2024

This PR detects duplications in the following:

  • Group ID
  • Metric name
  • Group name (e.g., resource and event names)

Since there are existing duplications in the current registries (see the example below), we return warnings instead of errors. As usual, the --future flag must be used for future versions of the registry.

Example: https://github.com/search?q=repo%3Aopen-telemetry%2Fsemantic-conventions+path%3A%2F%5Emodel%5C%2F%2F+feature_flag&type=code

For now, the group name duplication detection is disabled.

Closes #306

@lquerel lquerel requested a review from a team as a code owner September 20, 2024 00:49
@lquerel lquerel self-assigned this Sep 20, 2024
@lquerel lquerel added the enhancement New feature or request label Sep 20, 2024
@jsuereth
Copy link
Contributor

jsuereth commented Nov 6, 2024

@lquerel I think this is unblocked now if you can update the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Next Release
Development

Successfully merging this pull request may close these issues.

Check group id, metric name, and event name uniqueness
2 participants