-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semantic convention of influxDB #949
Conversation
@steverao do you envision adding any specifics about InfluxDB? Like custom attributes, metrics, some non-obvious mapping for common attributes? If the goal is to add a constant for |
At present, besides |
@steverao it does not look like influxDB needs any customization on top of generic attributes and descriptions we have for common DB attributes/spans. Am I correct? There is no requirement to add a semconv file for each DB and I'd prefer if we just added a constant system name unless we have something custom. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Yes, for the plugin, it don't contain special customization.
At first, I saw other database plugins provide relevant YAML document, so I added it for InfluxDB. For this situation, don' you recommend to add its unique YAML document? In the document, I added some explanations for its attributes. I think it will be better if we conserve it. If you think it's not necessary. I can delete it later. |
Thanks for the context! It seems that InfluxDB usage of common attributes is very well aligned with common definitions (database name is used in |
Thank you for your explanation! I deleted other contents except |
Co-authored-by: Liudmila Molkova <[email protected]>
Changes
Please provide a brief description of the changes here.
Add semantic convention of influxDB. Relative to open-telemetry/opentelemetry-java-instrumentation#10850
Merge requirement checklist
[chore]