Skip to content

Commit

Permalink
Address comment problems
Browse files Browse the repository at this point in the history
  • Loading branch information
steverao committed Apr 26, 2024
1 parent d7f1cb1 commit d192f59
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions docs/database/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Technology specific semantic conventions are defined for the following databases
* [CouchDB](couchdb.md): Semantic Conventions for *CouchDB*.
* [Elasticsearch](elasticsearch.md): Semantic Conventions for *Elasticsearch*.
* [HBase](hbase.md): Semantic Conventions for *HBase*.
* [InfluxDB](influxdb.md): Semantic Conventions for *InfluxDB*.
* [MongoDB](mongodb.md): Semantic Conventions for *MongoDB*.
* [MSSQL](mssql.md): Semantic Conventions for *MSSQL*.
* [Redis](redis.md): Semantic Conventions for *Redis*.
Expand Down
6 changes: 3 additions & 3 deletions docs/database/influxdb.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ described on this page.
<!-- semconv db.influxdb(full,tag=tech-specific) -->
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
|---|---|---|---|---|---|
| [`db.name`](../attributes-registry/db.md) | string | The InfluxDB database name. [1] | `mydb` | `Required` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`db.namespace`](../attributes-registry/db.md) | string | The InfluxDB database name. [1] | `mydb` | `Required` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`db.operation.name`](../attributes-registry/db.md) | string | The name of the command being executed. [2] | `CREATE DATABASE`; `DROP DATABASE`; `SELECT`; `write` | `Required` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |

**[1]:** For InfluxDB the `db.name` should be set to the InfluxDB database name.
**[1]:** For InfluxDB the `db.namespace` should be set to the InfluxDB database name.

**[2]:** See [InfluxDB database commands](https://docs.influxdata.com/influxdb/v1/query_language/).
<!-- endsemconv -->
Expand All @@ -32,7 +32,7 @@ described on this page.
|:--------------------|:----------------------------------|
| Span name | `"SELECT mydb"` |
| `db.system` | `"influxdb"` |
| `db.name` | `"mydb"` |
| `db.namespace` | `"mydb"` |
| `server.address` | `"localhost"` |
| `server.port` | `"32771"` |
| `db.statement` | `"SELECT * FROM mydb GROUP BY *"` |
Expand Down
4 changes: 2 additions & 2 deletions model/trace/database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,10 @@ groups:
brief: >
Attributes for InfluxDB
attributes:
- ref: db.name
- ref: db.namespace
brief: >
The InfluxDB database name.
note: For InfluxDB the `db.name` should be set to the InfluxDB database name.
note: For InfluxDB the `db.namespace` should be set to the InfluxDB database name.
examples: [ 'mydb' ]
requirement_level: required
tag: tech-specific
Expand Down

0 comments on commit d192f59

Please sign in to comment.