New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce common `messaging.consumer.group.name` and `messaging.destination.subscription.name` instead of per-system ones #815

Merged

lmolkova merged 1 commit into open-telemetry:main from lmolkova:messaging-consumer-group-common

Jun 19, 2024

Contributor

lmolkova commented Mar 14, 2024 •

edited

Loading

Changes

Addresses consumer group and subscription name part of #797

Merge requirement checklist

CONTRIBUTING.md guidelines followed.
Change log entry added, according to the guidelines in When to add a changelog entry.
- If your PR does not need a change log, start the PR title with [chore]
schema-next.yaml updated with changes to existing conventions.

lmolkova marked this pull request as ready for review

March 14, 2024 01:37

lmolkova requested review from a team

March 14, 2024 01:37

lmolkova commented

View reviewed changes

docs/attributes-registry/messaging.md Outdated Show resolved Hide resolved

lmolkova commented

View reviewed changes

docs/attributes-registry/messaging.md Outdated Show resolved Hide resolved

lmolkova commented

View reviewed changes

docs/messaging/rocketmq.md Outdated Show resolved Hide resolved

lmolkova force-pushed the messaging-consumer-group-common branch from 506dcc8 to d0f0cfc Compare

March 14, 2024 01:45

lmolkova commented

View reviewed changes

docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved

Contributor Author

lmolkova commented Mar 14, 2024

It sounds like we have two popular terms - "consumer group" and "subscription" to describe load/balancing + fan-out. Some systems even use both notions (RocketMQ).

I'm totally open to other naming suggestions depending on the feedback.

lmolkova changed the title ~~Introduce common messaging.consumer.group.name instead of per-system ones~~ Introduce common messaging.consumer.group.name instead of per-system ones

lmolkova commented

View reviewed changes

.chloggen/815.yaml Outdated Show resolved Hide resolved

lmolkova commented

View reviewed changes

model/registry/messaging.yaml Show resolved Hide resolved

github-actions bot assigned AlexanderWert

lmolkova marked this pull request as draft

March 14, 2024 19:08

pyohannes reviewed

View reviewed changes

Contributor

pyohannes left a comment

This looks fine to me.

I like that we actually not use the term "consumer group", but we have "group" as a sub-namespace of the "consumer" namespace. So this denotes a grouping of consumers, which can also apply to subscriptions.

docs/attributes-registry/messaging.md Outdated Show resolved Hide resolved

pyohannes linked an issue

that may be closed by this pull request

Messaging: generalize common attributes to future-proof metrics #797

Closed

lmolkova force-pushed the messaging-consumer-group-common branch from d0f0cfc to 2810697 Compare

April 18, 2024 23:58

lmolkova changed the title ~~Introduce common messaging.consumer.group.name instead of per-system ones~~ Introduce common messaging.consumer.group.name and messaging.destination.subscription.name instead of per-system ones

lmolkova marked this pull request as ready for review

April 19, 2024 00:08

github-actions bot assigned jsuereth

lmolkova force-pushed the messaging-consumer-group-common branch from 091ed64 to f9b94d5 Compare

April 19, 2024 00:09

lmolkova unassigned jsuereth and AlexanderWert

pyohannes reviewed

View reviewed changes

docs/messaging/messaging-spans.md Show resolved Hide resolved

model/registry/messaging.yaml Outdated Show resolved Hide resolved

lmolkova force-pushed the messaging-consumer-group-common branch from 8db3110 to b9d1120 Compare

May 2, 2024 20:46

lmolkova mentioned this pull request

Messaging metric overrides #687

Closed

3 tasks

github-actions bot commented May 18, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

lmolkova removed the Stale label

pyohannes approved these changes

View reviewed changes

Contributor

pyohannes left a comment

Thanks @lmolkova, I think that's good to go.

docs/messaging/messaging-spans.md Show resolved Hide resolved

joaopgrassi reviewed

View reviewed changes

model/registry/messaging.yaml Show resolved Hide resolved

docs/messaging/kafka.md Show resolved Hide resolved

lmolkova force-pushed the messaging-consumer-group-common branch from 22a3723 to 9b65eba Compare

June 14, 2024 22:36

lmolkova requested review from pyohannes and joaopgrassi

June 14, 2024 22:37

joaopgrassi approved these changes

View reviewed changes

pyohannes approved these changes

View reviewed changes


          Introduce common messaging.consumer.group.name and messaging.destinat…

0f7fbdb

…ion.subscription.name instead of per-system ones

lmolkova force-pushed the messaging-consumer-group-common branch from 9b65eba to 0f7fbdb Compare

June 19, 2024 19:06

lmolkova merged commit c195520 into open-telemetry:main

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet