Messaging metric overrides #687
Conversation
lmolkova
force-pushed
the
messaging-azure-metric-overrides
branch
from
58cdce8 to
34f2d2e
Compare
lmolkova
force-pushed
the
messaging-azure-metric-overrides
branch
from
faa5537 to
6b70542
Compare
| - The following attributes (with corresponding [requirement levels](#attributes)) are defined in addition to generic attributes for this metric: | ||
| * `messaging.kafka.destination.partition` | ||
| * `messaging.kafka.consumer.group` |
There was a problem hiding this comment.
We will need to clarify with the wider semantic conventions community whether this is the way we want to extend generic metric definitions.
The approach proposed in this PR is endorsed by the messaging workgroup, because it allows telemetry consumers to utilize a single metric (for example messaging.receive.messages) to measure throughput, regardless of the messaging system used. This makes it much easier to build generic APM experiences.
For obtaining system-specific information, it is still possible to utilize the additional system-specific attributes on the metric.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
| - [Span attributes](#span-attributes) | ||
| - [Attributes](#attributes) | ||
| - [Metrics](#metrics) | ||
| * [Metric: `messaging.publish.duration`](#metric-messagingpublishduration) |
There was a problem hiding this comment.
I wonder, didn't we had a person working on the Kakfa metrics and decided to not have them in semconv? How these will fit with those? Or are those broker and these are client ones?
|
I'm going to close it for now since it might not be needed with #815 |
Fixes #553
Changes
Documents individual messaging system metric overrides for Kafka, RabbitMQ and Azure messaging systems
Merge requirement checklist