Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two fixes to the HTTP semconv migration guide #804

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

trask
Copy link
Member

@trask trask commented Mar 8, 2024

Fixes #802

Changes

  • Include that server.port is now captured even when same as default port for the scheme
  • Include network.local.port and network.local.port under HTTP server spans

@trask trask force-pushed the migration branch 3 times, most recently from 477f15e to 67ccf42 Compare March 8, 2024 21:22
@trask trask changed the title Two fixes to HTTP semconv migration guide Two fixes to the HTTP semconv migration guide Mar 8, 2024
@trask trask force-pushed the migration branch 2 times, most recently from 7152fd9 to 616e50c Compare March 8, 2024 21:30
@trask trask marked this pull request as ready for review March 8, 2024 21:34
@trask trask requested review from a team March 8, 2024 21:34
@lmolkova lmolkova merged commit e24b332 into open-telemetry:main Mar 12, 2024
10 checks passed
@trask trask deleted the migration branch March 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Two fixes to the HTTP semconv migration guide
6 participants