Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two fixes to the HTTP semconv migration guide #802

Closed
trask opened this issue Mar 8, 2024 · 0 comments · Fixed by #804
Closed

Two fixes to the HTTP semconv migration guide #802

trask opened this issue Mar 8, 2024 · 0 comments · Fixed by #804
Assignees
@trask

Comments

@trask
Copy link
Member

trask commented Mar 8, 2024

A couple of things that need to be fixed:

  • Under net.host.port -> server.port, mention that it used to be optional when it matched the http.scheme, but is now required
  • There's no mention of net.sock.host.addr and net.sock.host.port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trask trask

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Two fixes to the HTTP semconv migration guide trask/semantic-conventions
2 participants
@trask @reyang