-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging: clarify network attributes usage on common semconv #698
Messaging: clarify network attributes usage on common semconv #698
Conversation
From the messaging point of view, I'd agree to merge those changes. |
f1fabe3
to
4cae674
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great to look over the existing Java database instrumentations to see how many places where we're (usefully/correctly?) capturing network attributes
Looking into java instrumentation repo: Messaging systems:
Databases:
All instrumentations that report network, report only I probably missed something, but I think there is enough evidence.
|
Thanks @lmolkova for this research. To add one more datapoint, the .NET RabbitMQ instrumentation populates both network and server attributes (if they are available):
|
5dd535a
to
11df88f
Compare
Based on the discussion in Messaging SIG, breaking this one down into two PRs. This one contains messaging portion only. Will send a separate one for DBs. |
efb2771
to
405e120
Compare
9b9e055
to
823e6e0
Compare
Based on the database discussion on similar PR #768 (comment), I updated this one to be consistent with databases:
@open-telemetry/semconv-messaging-approvers please re-review |
823e6e0
to
cd68332
Compare
b3b354e
to
4594a7f
Compare
8f1338f
to
7afa1b6
Compare
Changes
Addresses messaging portion of #690
Removes
network.transport|type
attributes from general messaging semantic conventions.Based on the findings from Java instrumentation libraries, the only messaging instrumentation that populates network attributes is RabbitMQ (which also sets them in native .NET instrumentation).
This PR clarifies that
network.server.address|port
should be only set when they represent a specific broker instance (when individual instances are visible from the application side) and recommends to use them on the RabbitMQ (as one of the systems that's usually self-hosted)Merge requirement checklist
[chore]
schema-next.yaml