Update body size attribute and metric definitions #461
+14
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
update-body-size-definition
branch
from
67bf12d to
d98019c
Compare
trask
commented
Oct 27, 2023
model/registry/http.yaml
Outdated
| examples: 3495 | ||
| stability: experimental # this should not be marked stable with other HTTP attributes |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #456 (comment) (and #460)
Changes
Updates HTTP body size attributes and metric definitions to be the number of bytes transferred, as opposed to being defined in terms of
Content-Lengthwhich may or may not be present, and which may or may not reflect the actual number of bytes transferred.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.