Skip to content

Commit

Permalink
Update body size attribute and metric definitions
Browse files Browse the repository at this point in the history
  • Loading branch information
trask committed Oct 27, 2023
1 parent 03aba2a commit 67bf12d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 20 deletions.
16 changes: 4 additions & 12 deletions model/metrics/http.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ groups:
instrument: histogram
unit: "By"
note: >
The size of the request payload body in bytes. This is the number of bytes transferred excluding headers and
is often, but not always, present as the [Content-Length](https://www.rfc-editor.org/rfc/rfc9110.html#field.content-length)
header. For requests using transport encoding, this should be the compressed size.
This is the same as the `Content-Length` header value when that header is present and when the response body was fully transferred.
extends: metric_attributes.http.server

- id: metric.http.server.response.body.size
Expand All @@ -85,9 +83,7 @@ groups:
instrument: histogram
unit: "By"
note: >
The size of the response payload body in bytes. This is the number of bytes transferred excluding headers and
is often, but not always, present as the [Content-Length](https://www.rfc-editor.org/rfc/rfc9110.html#field.content-length)
header. For requests using transport encoding, this should be the compressed size.
This is the same as the `Content-Length` header value when that header is present and when the response body was fully transferred.
extends: metric_attributes.http.server

- id: metric.http.client.request.duration
Expand All @@ -105,9 +101,7 @@ groups:
instrument: histogram
unit: "By"
note: >
The size of the request payload body in bytes. This is the number of bytes transferred excluding headers and
is often, but not always, present as the [Content-Length](https://www.rfc-editor.org/rfc/rfc9110.html#field.content-length)
header. For requests using transport encoding, this should be the compressed size.
This is the same as the `Content-Length` header value when that header is present and when the request body was fully transferred.
extends: metric_attributes.http.client

- id: metric.http.client.response.body.size
Expand All @@ -117,7 +111,5 @@ groups:
instrument: histogram
unit: "By"
note: >
The size of the response payload body in bytes. This is the number of bytes transferred excluding headers and
is often, but not always, present as the [Content-Length](https://www.rfc-editor.org/rfc/rfc9110.html#field.content-length)
header. For requests using transport encoding, this should be the compressed size.
This is the same as the `Content-Length` header value when that header is present and when the response body was fully transferred.
extends: metric_attributes.http.client
16 changes: 8 additions & 8 deletions model/registry/http.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ groups:
attributes:
- id: request.body.size
type: int
brief: >
The size of the request payload body in bytes. This is the number of bytes transferred excluding headers and
is often, but not always, present as the [Content-Length](https://www.rfc-editor.org/rfc/rfc9110.html#field.content-length)
header. For requests using transport encoding, this should be the compressed size.
brief: Size of the HTTP request body.
examples: 3495
stability: experimental # this should not be marked stable with other HTTP attributes

Check warning on line 11 in model/registry/http.yaml

View workflow job for this annotation

GitHub Actions / yamllint

[comments] too few spaces before comment
note: >
This is the same as the `Content-Length` header value when that header is present and when the request body was fully transferred.
- id: request.header
type: template[string[]]
brief: >
Expand Down Expand Up @@ -92,11 +92,11 @@ groups:
examples: 3
- id: response.body.size
type: int
brief: >
The size of the response payload body in bytes. This is the number of bytes transferred excluding headers and
is often, but not always, present as the [Content-Length](https://www.rfc-editor.org/rfc/rfc9110.html#field.content-length)
header. For requests using transport encoding, this should be the compressed size.
brief: Size of the HTTP response body.
examples: 3495
stability: experimental # this should not be marked stable with other HTTP attributes

Check warning on line 97 in model/registry/http.yaml

View workflow job for this annotation

GitHub Actions / yamllint

[comments] too few spaces before comment
note: >
This is the same as the `Content-Length` header value when that header is present and when the response body was fully transferred.
- id: response.header
type: template[string[]]
brief: >
Expand Down

0 comments on commit 67bf12d

Please sign in to comment.