Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repetitive notes, briefs, etc on ref attributes #367

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 3, 2023

Fixes #358

Changes

Leverages open-telemetry/build-tools#204 allowing to use inherited properties of attributes when referencing them.

Merge requirement checklist

@lmolkova
Copy link
Contributor Author

lmolkova commented Oct 3, 2023

Waiting for #342 to go in first to avoid a massive merge there.

@trask
Copy link
Member

trask commented Oct 10, 2023

@lmolkova #342 is just merged now

@lmolkova lmolkova changed the title Editorial: Remove repetitive notes, briefs, etc on ref attributes Remove repetitive notes, briefs, etc on ref attributes Oct 10, 2023
@lmolkova lmolkova marked this pull request as ready for review October 10, 2023 21:24
@lmolkova lmolkova requested review from a team October 10, 2023 21:24
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joaopgrassi joaopgrassi merged commit ec3a4cf into open-telemetry:main Oct 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Proofreading: network.protocol.* definition is different between HTTP metrics and spans
6 participants