Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for attributes semconv generation #133

Closed
lmolkova opened this issue Feb 8, 2023 · 4 comments
Closed

Improvements for attributes semconv generation #133

lmolkova opened this issue Feb 8, 2023 · 4 comments
Labels
bug Something isn't working semconv/model Related to the data model or YAML format of the semantic convention generator semconv Related to the semantic convention generator.

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Feb 8, 2023

open-telemetry/opentelemetry-specification#3183 declares attributes separately from traces and metrics and then reuses attributes in corresponding semconvs. There are two issues:

  1. Grandparent attributes are not populated in the table. E.g.

    • http.common group defines http.method
    • http.server group extends http.common and defines http.route
    • metric.http.server.duration extends http.server. When metric.http.server.duration(full) semconv table is rendered, it does not include http.method, but includes http.route
  2. Referenced attributes description should come from extended semconv first. E.g.

    • net.peer.name is defined in span-general semconv
    • it's redefined for HTTP in http.client.common providing long HTTP-specific description
    • it needs sampling_relevant: true for tracing (and none of it for metrics), so it has to be referenced again in trace.http.client and long HTTP-specific description should be repeated
    • Proposal: when resolving net.peer.name for trace.http.client semconv, it should prioritize properties from trace.http.client, then read them from parent (http.client.common) and finally fill in the gaps from original span-general spec.
@trask
Copy link
Member

trask commented Feb 13, 2023

stable attribute ordering would be wonderful also

@marcalff
Copy link
Member

marcalff commented Mar 6, 2023

This not only affect table generation, but also affects code generation.

@Oberon00
Copy link
Member

This seems like a bug more than a feature request. The extends implementation attempts to iterate repeatedly until a "fixpoint" is reached, i.e. it aims to support grandparent attributes, they should even be indistinguishable from parent attributes.

@Oberon00 Oberon00 added bug Something isn't working semconv Related to the semantic convention generator. semconv/model Related to the data model or YAML format of the semantic convention generator labels Apr 25, 2023
@lmolkova
Copy link
Contributor Author

lmolkova commented Oct 3, 2023

This is fixed now with #204.
Here open-telemetry/semantic-conventions#367 we have inherited properties (p2) and grandparent attributes populated (p1).

@lmolkova lmolkova closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semconv/model Related to the data model or YAML format of the semantic convention generator semconv Related to the semantic convention generator.
Projects
None yet
Development

No branches or pull requests

4 participants