Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmosDB: define applicable values for db.operation.name and add proper reference to az.namespace #1330

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Aug 9, 2024

  • List operations names for Cosmos DB clients.
  • Lowercase operation_type value.
  • Add az.namespace attribute and reference it (previously undefined, but referenced in md)
  • Clean up examples

Merge requirement checklist

@lmolkova lmolkova requested review from a team August 9, 2024 18:26
@lmolkova lmolkova changed the title CosmosDB: define applicable values for db.operation.name CosmosDB: define applicable values for db.operation.name and add proper reference to az.namespace Aug 9, 2024
.chloggen/1330.yaml Outdated Show resolved Hide resolved
model/trace/database.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the cosmos-define-operation-names branch from 7f257df to 5391024 Compare August 9, 2024 19:58
model/trace/database.yaml Outdated Show resolved Hide resolved
Copy link

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think transactional batch but especially bulk needs some more thoughts. Bulk operations are done fundamentally differently in Java and .Net. In Bulk there is an explicit API for executing a set of operations as bulk - so something like execute_bulk would probably be good? In .Net whether point operations are executed as bulk or normally depends on some config on the client - which right now you result in create or read covering operations that are actually executed as part of a bulk operation and would have completely different non-functional characteristics like perf.

model/trace/database.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the cosmos-define-operation-names branch from aead156 to 4179c49 Compare August 16, 2024 21:39
Copy link
Contributor

@jcocchi jcocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left one minor comment

docs/database/cosmosdb.md Outdated Show resolved Hide resolved
Copy link

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@lmolkova lmolkova force-pushed the cosmos-define-operation-names branch from 4179c49 to d34d6cb Compare August 22, 2024 03:27
@lmolkova lmolkova merged commit 3c16c80 into open-telemetry:main Aug 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants