-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CosmosDB: define applicable values for db.operation.name
and add proper reference to az.namespace
#1330
CosmosDB: define applicable values for db.operation.name
and add proper reference to az.namespace
#1330
Conversation
db.operation.name
db.operation.name
and add proper reference to az.namespace
7f257df
to
5391024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think transactional batch but especially bulk needs some more thoughts. Bulk operations are done fundamentally differently in Java and .Net. In Bulk there is an explicit API for executing a set of operations as bulk - so something like execute_bulk
would probably be good? In .Net whether point operations are executed as bulk or normally depends on some config on the client - which right now you result in create
or read
covering operations that are actually executed as part of a bulk operation and would have completely different non-functional characteristics like perf.
aead156
to
4179c49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Left one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
4179c49
to
d34d6cb
Compare
az.namespace
attribute and reference it (previously undefined, but referenced in md)Merge requirement checklist
[chore]