-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos DB: Add support for Span #23268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
kirankumarkolli,
simorenoh,
kushagraThapar and
Pilchie
as code owners
August 1, 2024 22:22
jhendrixMSFT
approved these changes
Aug 1, 2024
kushagraThapar
approved these changes
Aug 2, 2024
lmolkova
reviewed
Aug 3, 2024
lmolkova
reviewed
Aug 3, 2024
…-sdk-for-go into users/ealsur/tracer
lmolkova
reviewed
Aug 9, 2024
lmolkova
reviewed
Aug 9, 2024
lmolkova
reviewed
Aug 9, 2024
This was referenced Aug 11, 2024
lmolkova
approved these changes
Aug 11, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
Client
to have the internalazcore.Client
embedded to leverage the Pipeline and Trace.All the methods (except Pagers because they internally already do it) that execute an async operation will now start a Span respectively.
Added a helper SpanValidator to be used in tests to validate that the expected Spans are generated.
Properties
Reference: https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/database/cosmosdb.md
TracingOptions
to setaz.namespace
toMicrosoft.DocumentDB
db.system
=cosmosdb
db.cosmosdb.connection_mode
=gateway
db.namespace
(when applicable) = datbase iddb.collection.name
(when applicable) = container iddb.operation.name
= span name (for examplecreate_container
)server.address
andserver.port
= based on the endpoint (for examplemyaccount.documents.azure.com
,server.port
is added only if it's different than 443)Span names
Covers the list in
azure-sdk-for-go/sdk/data/azcosmos/otel_constants.go
Lines 15 to 35 in 29ab511
Closes #23185