Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp messaging metrics to support generic operations #1006

Merged
merged 13 commits into from
Jun 14, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented May 4, 2024

Fixes #947, #937

Changes

  • make messaging.operation.name required and messaging.operation.type conditionally required
  • update span name accordingly (and follow other semconv pattern of {operation} {destination})
  • update metrics:
    • Make messaging.operation.name required and messaging.operation.type conditionally required when type is applicable.
    • Unify messaging.publish.duration and messaging.receive.duration metrics into messaging.client.operation.duration
    • Unify messaging.receive.messages and messaging.process.messages metrics into messaging.client.consumed.messages

Merge requirement checklist

@lmolkova lmolkova force-pushed the messaging-revamp-metrics branch 2 times, most recently from 4511bc0 to 86ee3c9 Compare May 4, 2024 05:14
@lmolkova lmolkova force-pushed the messaging-revamp-metrics branch from 86ee3c9 to 0593db2 Compare May 7, 2024 23:38
@lmolkova lmolkova marked this pull request as ready for review May 8, 2024 05:01
@lmolkova lmolkova requested review from a team May 8, 2024 05:01
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lmolkova, I think this is going in a good direction.

docs/attributes-registry/messaging.md Outdated Show resolved Hide resolved
docs/messaging/messaging-metrics.md Outdated Show resolved Hide resolved
docs/messaging/messaging-metrics.md Outdated Show resolved Hide resolved
docs/messaging/messaging-metrics.md Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the messaging-revamp-metrics branch from 18f8142 to 19cd105 Compare May 9, 2024 04:34
.chloggen/1006.yaml Outdated Show resolved Hide resolved
.chloggen/1006.yaml Outdated Show resolved Hide resolved
model/trace/messaging.yaml Outdated Show resolved Hide resolved
model/trace/messaging.yaml Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
docs/messaging/messaging-metrics.md Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
schema-next.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the messaging-revamp-metrics branch 2 times, most recently from 4010ef2 to 203ebb3 Compare May 30, 2024 01:57
@lmolkova lmolkova force-pushed the messaging-revamp-metrics branch 5 times, most recently from 1b78dd5 to 69bfd72 Compare May 30, 2024 22:07
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lmolkova, it feels we're getting quite close!

docs/messaging/messaging-metrics.md Outdated Show resolved Hide resolved
docs/messaging/messaging-metrics.md Outdated Show resolved Hide resolved
model/metrics/messaging-metrics.yaml Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some smaller remarks, but nothing that should block merging this. I'm looking forward to first prototypes based on these changes.

docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
docs/messaging/messaging-spans.md Show resolved Hide resolved
docs/messaging/messaging-spans.md Show resolved Hide resolved
@lmolkova lmolkova force-pushed the messaging-revamp-metrics branch from de27752 to 861abd2 Compare June 5, 2024 19:52
.chloggen/1006.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the messaging-revamp-metrics branch from b8480d3 to 9504ad5 Compare June 7, 2024 19:55
@trask
Copy link
Member

trask commented Jun 7, 2024

  • deprecate messaging.operation.type

and

  • unify ... in one messaging.client.operation.duration

looks like drift on this parts of PR description

model/metrics/messaging-metrics.yaml Outdated Show resolved Hide resolved
model/metrics/messaging-metrics.yaml Show resolved Hide resolved
@lmolkova lmolkova force-pushed the messaging-revamp-metrics branch from cbe6c53 to b6008e8 Compare June 11, 2024 00:10
@lmolkova lmolkova merged commit cde003c into open-telemetry:main Jun 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Messaging.operation.type attribute should not be required
4 participants