-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp messaging metrics to support generic operations #1006
Revamp messaging metrics to support generic operations #1006
Conversation
4511bc0
to
86ee3c9
Compare
86ee3c9
to
0593db2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lmolkova, I think this is going in a good direction.
18f8142
to
19cd105
Compare
4010ef2
to
203ebb3
Compare
1b78dd5
to
69bfd72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @lmolkova, it feels we're getting quite close!
eae8b8c
to
de27752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some smaller remarks, but nothing that should block merging this. I'm looking forward to first prototypes based on these changes.
de27752
to
861abd2
Compare
b8480d3
to
9504ad5
Compare
and
looks like drift on this parts of PR description |
cbe6c53
to
b6008e8
Compare
Fixes #947, #937
Changes
messaging.operation.name
required andmessaging.operation.type
conditionally required{operation} {destination}
)messaging.operation.name
required andmessaging.operation.type
conditionally required when type is applicable.messaging.publish.duration
andmessaging.receive.duration
metrics intomessaging.client.operation.duration
messaging.receive.messages
andmessaging.process.messages
metrics intomessaging.client.consumed.messages
Merge requirement checklist
[chore]