Skip to content

Commit

Permalink
span name code review
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Jun 5, 2024
1 parent 6be0396 commit 861abd2
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions docs/messaging/messaging-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,14 @@ Messaging spans SHOULD follow the overall [guidelines for span names](https://gi
The **span name** SHOULD be `{messaging.operation.name} {destination}` (see below for the exact definition of the [`{destination}`](#destination-placeholder) placeholder).
<!-- markdown-link-check-enable -->

If neither `{messaging.operation.name}` nor `{destination}` are available, span name SHOULD be `{messaging.system}`.

Semantic conventions for individual messaging systems MAY specify different span name format and then MUST document it in [semantic conventions for specific messaging technologies](#semantic-conventions-for-specific-messaging-technologies).

The <span id="destination-placeholder">`{destination}`</span> SHOULD describe the entity that the operation is performed against
and SHOULD adhere to one of the following values, provided they are accessible:

- `messaging.destination.template` or `messaging.destination.name` SHOULD be used for operations on messages or messaging destinations.
The `messaging.destination.template` SHOULD be used whenever it's available. Otherwise, `messaging.destination.name` SHOULD be used only when
the destination is known to be neither [temporary nor anonymous](#temporary-and-anonymous-destinations).
- `server.address:server.port` SHOULD be used for other operations not targeting any specific destination(s).
1. `messaging.destination.template` SHOULD be used when it is available.
2. `messaging.destination.name` SHOULD be used when the destination is known to be neither [temporary nor anonymous](#temporary-and-anonymous-destinations).
3. `server.address:server.port` SHOULD be used for operations not targeting any specific destination(s).

If a corresponding `{destination}` value is not available for a specific operation, the instrumentation SHOULD omit the `{destination}`.

Expand Down

0 comments on commit 861abd2

Please sign in to comment.