Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

minor fixes in the sampling RFC #50

Merged
merged 3 commits into from
Jan 9, 2020

Conversation

hmdhk
Copy link
Contributor

@hmdhk hmdhk commented Sep 16, 2019

No description provided.

@hmdhk
Copy link
Contributor Author

hmdhk commented Sep 16, 2019

I signed it

Oberon00 pushed a commit to dynatrace-oss-contrib/oteps that referenced this pull request Sep 16, 2019
text/0006-sampling.md Outdated Show resolved Hide resolved
@bogdandrutu
Copy link
Member

@jahtalab please address feedback :)

@hmdhk hmdhk force-pushed the sampling-rfc-fixes branch from 64db0c1 to 9b577ff Compare November 7, 2019 16:37
@hmdhk hmdhk requested a review from tigrannajaryan as a code owner November 7, 2019 16:37
@hmdhk
Copy link
Contributor Author

hmdhk commented Nov 7, 2019

@bogdandrutu , please have another look.

@hmdhk
Copy link
Contributor Author

hmdhk commented Jan 6, 2020

Are there any changes required for this PR?

cc @songy23, @tedsuo

@bogdandrutu bogdandrutu requested a review from jmacd as a code owner January 9, 2020 16:48
@bogdandrutu
Copy link
Member

Merging this as admin, only cleanups.

@bogdandrutu bogdandrutu merged commit 413c03c into open-telemetry:master Jan 9, 2020
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
* minor fixes in the sampling RFC

* address review comments

Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
* minor fixes in the sampling RFC

* address review comments

Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 30, 2024
* minor fixes in the sampling RFC

* address review comments

Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Nov 8, 2024
* minor fixes in the sampling RFC

* address review comments

Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants