Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@hmdhk
hmdhk committed Nov 7, 2019
1 parent 491a7f5 commit 9b577ff
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions text/0006-sampling.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,11 @@ instrumenting code and never access `SampledFlag` unless used in context propaga
This is a new concept added in the OpenTelemetry API that allows to suggest sampling hints to the
implementation of the API:
* `NOT_RECORD`
* Suggest to not record (`RecordEvents = false`) and not propagate (`SampledFlag = false`).
* Suggest to not set (`RecordEvents = false`) and not propagate (`SampledFlag = false`).
* `RECORD`
* Suggest to record (`RecordEvents = true`) but not propagate (`SampledFlag = false`).
* Suggest to set (`RecordEvents = true`) but not propagate (`SampledFlag = false`).
* `RECORD_AND_PROPAGATE`
* Suggest to record (`RecordEvents = true`) and propagate (`SampledFlag = true`).
* Suggest to set (`RecordEvents = true`) and propagate (`SampledFlag = true`).

The default option for the span creation is to not have any suggestion (or suggestion is not
specified). This can be implemented by using `null` as the default option or any language specific
Expand Down

0 comments on commit 9b577ff

Please sign in to comment.