Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Add Makefile and Circle CI config #14

Merged
merged 5 commits into from
Aug 9, 2019

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Aug 9, 2019

Fixes #13.
Currently the only job is misspell check.

@@ -0,0 +1,14 @@
version: 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm less familiar with Circle CI setup so gently paging @rghetia and @pavolloffay for a review.

Makefile Outdated
.PHONY: install-tools
install-tools:
GO111MODULE=on go install \
github.com/client9/misspell/cmd/misspell
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this approach to install tools locally to guarantee that same version is used.

Copy link
Member Author

@songy23 songy23 Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated in 396b249.

@bogdandrutu bogdandrutu closed this Aug 9, 2019
@bogdandrutu bogdandrutu reopened this Aug 9, 2019
@rghetia
Copy link

rghetia commented Aug 9, 2019

@songy23 the failure may be due to filename .circleci.yaml instead of .circleci.yml

@songy23
Copy link
Member Author

songy23 commented Aug 9, 2019

@rghetia That fixed it - thanks!

@bogdandrutu bogdandrutu merged commit 952166d into open-telemetry:master Aug 9, 2019
@songy23 songy23 deleted the misspell branch August 9, 2019 21:52
songy23 added a commit to songy23/opentelemetry-specification that referenced this pull request Aug 23, 2019
Also update Makefile to build tools locally.
Similar to open-telemetry/oteps#14.
songy23 added a commit to songy23/opentelemetry-specification that referenced this pull request Aug 23, 2019
Also update Makefile to build tools locally.
Similar to open-telemetry/oteps#14.
songy23 added a commit to songy23/opentelemetry-specification that referenced this pull request Aug 23, 2019
Also update Makefile to build tools locally.
Similar to open-telemetry/oteps#14.
bogdandrutu pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Aug 23, 2019
Also update Makefile to build tools locally.
Similar to open-telemetry/oteps#14.
Oberon00 pushed a commit to dynatrace-oss-contrib/oteps that referenced this pull request Sep 16, 2019
* Add typed spans working document

* Restructuring and scoping

- Added motivation
- Provided a broader scope and less implementation details, like naming or mandatory fields
- Removed tables
SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
jsuereth pushed a commit to jsuereth/otel-semconv-test that referenced this pull request Apr 19, 2023
Also update Makefile to build tools locally.
Similar to open-telemetry/oteps#14.
jsuereth pushed a commit to open-telemetry/semantic-conventions that referenced this pull request May 11, 2023
Also update Makefile to build tools locally.
Similar to open-telemetry/oteps#14.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable misspell go tool
3 participants