Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaaS metrics - Introduce extra attributes to metrics #233

Open
joaopgrassi opened this issue Aug 7, 2023 · 2 comments
Open

FaaS metrics - Introduce extra attributes to metrics #233

joaopgrassi opened this issue Aug 7, 2023 · 2 comments
Assignees

Comments

@joaopgrassi
Copy link
Member

In #88 (comment) we discussed and aligned that all existing FaaS metrics are related to the FaaS itself and not by whoever is invoking them (clients).

Because of this, the conventions were modified and the attributes faas.invoked_name, faas.invoked_provider and faas.invoked_region were removed as those were supposed to be recorded on metrics captured by clients.

This in turn made the metrics only have the faas.trigger attribute. It was proposed that we recorded also the following attributes on all the FaaS metrics:

  • faas.name
  • cloud.provider
  • cloud.region

We should update the metrics and add the aforementioned attributes.

@jviau
Copy link

jviau commented Feb 7, 2024

For cloud.* attributes can we instead just say that all FaaS telemetry may include the cloud resource section? https://github.com/open-telemetry/semantic-conventions/blob/main/model/resource/cloud.yaml

@joaopgrassi
Copy link
Member Author

For cloud.* attributes can we instead just say that all FaaS telemetry may include the cloud resource section? main/model/resource/cloud.yaml

We have every attribute listed and try to move away from such wording, better to be explicit. So, the attributes need to be added one by one in the yaml file I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants