Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Update from open-telemetry/opentelemetry-collector #643

Conversation

austinlparker
Copy link
Member

This is an automated pull request.

@austinlparker austinlparker requested a review from a team July 19, 2021 23:14
@chalin
Copy link
Contributor

chalin commented Aug 12, 2021

Pinging @mtwo @flands -- Shouldn't these auto-generated PRs just require a RSLGTM and a click of the "Squash and Merge" button? If not, what's the process, and how can I help get these into the repo more quickly?

/cc @austinlparker @tedsuo

@@ -1,117 +0,0 @@
---
title: "Building a custom authenticator"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, when pages disappear, we should add an appropriate redirect rule. (Related: #635)

So, in this case, if a reader was interested in the content of this page (and the Authentication section on the parent page), where should they go to next for pertinent info?

/cc @bogdandrutu @tigrannajaryan

Copy link
Contributor

@chalin chalin Aug 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, when pages disappear, we should add an appropriate redirect rule. (Related: #635)

I've opened #668 #638 to track this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think #668 is the right link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks!

@chalin chalin added the docs label Aug 12, 2021
@chalin chalin merged commit 2e406a6 into main Aug 13, 2021
@chalin chalin deleted the docs-open-telemetry/opentelemetry-collector-7983af7be0d36988fb18732dc3c0f53cbd163439 branch August 13, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants