Drop and ignore package-lock.json #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
requested review from
austinlparker,
flands,
jparsana and
mtwo
as code owners
hdost
approved these changes
Jul 30, 2021
|
I'll defer to @austinlparker on this one |
chalin
force-pushed
the
chalin-drop-package-lock-2021-07-16
branch
2 times, most recently
from
1b9e921 to
2c64e6e
Compare
|
As discussed with @tedsuo and @mtwo out-of-band, @austinlparker might be out for a while still. Besides, this is a simplifying PR that is easily "reversed". |
In the spirit of open-telemetry#582 -- for a website, it isn't worth the hassle of maintaining this under version control, IMHO. cc @austinlparker
chalin
force-pushed
the
chalin-drop-package-lock-2021-07-16
branch
from
2c64e6e to
e348be2
Compare
|
After discussion with @tedsuo, I'm going ahead and merging infrastructure PRs like these (in particular because this one is easy to revert). |
|
Nope, apparently I don't have the permissions to do so. |
mtwo
approved these changes
Aug 12, 2021
|
Thanks! 🎉 |
This was referenced Aug 13, 2021
chalin
pushed a commit
that referenced
this pull request
Aug 13, 2021
RSLGTM, modulo #638, which we'll address later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #582 -- for a website, it isn't worth the hassle of maintaining this under version control, IMHO.
cc @austinlparker