Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing en anchors for ES translations #5580

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Add missing en anchors for ES translations #5580

merged 3 commits into from
Nov 12, 2024

Conversation

theletterf
Copy link
Member

Contributes to #5555

@theletterf theletterf requested a review from a team as a code owner November 11, 2024 08:54
@opentelemetrybot opentelemetrybot requested review from a team and krol3 and removed request for a team November 11, 2024 08:54
@svrnm
Copy link
Member

svrnm commented Nov 11, 2024

Can you also edit .htmltest.yml and remove the ignore rules accordingly? Thanks

@svrnm svrnm mentioned this pull request Nov 11, 2024
Open
5 tasks
@chalin
Copy link
Contributor

chalin commented Nov 11, 2024 •
edited
Loading

Can you also edit .htmltest.yml and remove the ignore rules accordingly? Thanks

Right, the ignore rules must be removed, in particular so that we can confirm the fix. But it needs to be removed from the front matter of content/es/docs/_index.md, and then the links re-checked (or you can npm run fix:htmltest-config).

@theletterf
Copy link
Member Author

@svrnm @chalin Done — now passing the tests! Thanks! Weirdly enough, I now get Netlify errors...

@opentelemetrybot opentelemetrybot requested review from a team November 12, 2024 11:15
chalin
chalin approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@svrnm svrnm added this pull request to the merge queue Nov 12, 2024
Merged via the queue into open-telemetry:main with commit d65dd0e Nov 12, 2024
17 checks passed
drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Nov 21, 2024
@theletterf @drewby
Add missing en anchors for ES translations (open-telemetry#5580)
045a384
drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Dec 5, 2024
@theletterf @drewby
Add missing en anchors for ES translations (open-telemetry#5580)
365e1a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@svrnm svrnm svrnm approved these changes

@krol3 krol3 Awaiting requested review from krol3 krol3 was automatically assigned from open-telemetry/docs-es-approvers

Assignees
No one assigned
Labels
lang:es
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theletterf @svrnm @chalin