Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Render-link fix: prepend lang code when page exists #5554

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[i18n] Render-link fix: prepend lang code when page exists #5554

merged 2 commits into from
Nov 7, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 7, 2024 •
edited
Loading

@chalin chalin requested a review from a team as a code owner November 7, 2024 23:00
@chalin chalin marked this pull request as draft November 7, 2024 23:00
@chalin chalin added the CI/infra CI & infrastructure label Nov 7, 2024
@chalin chalin mentioned this pull request Nov 7, 2024
Open
5 tasks
@chalin chalin marked this pull request as ready for review November 7, 2024 23:17
@opentelemetrybot opentelemetrybot requested review from a team and mx-psi and removed request for a team November 7, 2024 23:17
@chalin chalin changed the title Render-link fix in support of i18n: prepend lang code when page exists [i18n] Render-link fix: prepend lang code when page exists Nov 7, 2024
tiffany76
tiffany76 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@chalin chalin merged commit e7c30e9 into open-telemetry:main Nov 7, 2024
17 checks passed
@chalin chalin deleted the chalin-im-render-link-i18n-2024-11-07 branch November 7, 2024 23:39
@chalin
Copy link
Contributor Author

chalin commented Nov 7, 2024

In summary, this PR will help:

  • Identify missing heading IDs in new non-en pages as soon as the new page is submitted.
  • Provide a better UX: non-en locale page navigation will stay in the locale even if fallback pages are visited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi was automatically assigned from open-telemetry/docs-es-approvers

Assignees
No one assigned
Labels
CI/infra CI & infrastructure lang:es lang:fr lang:ja lang:pt lang:zh
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render-link hook isn't generating locale specific paths when possible
2 participants
@chalin @tiffany76