Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render-link hook isn't generating locale specific paths when possible #5553

Closed
chalin opened this issue Nov 7, 2024 · 0 comments · Fixed by #5554
Closed

Render-link hook isn't generating locale specific paths when possible #5553

chalin opened this issue Nov 7, 2024 · 0 comments · Fixed by #5554
Assignees
Labels
bug Something isn't working CI/infra CI & infrastructure i18n internationalization p1-high

Comments

@chalin
Copy link
Contributor

chalin commented Nov 7, 2024

While PR #4689 was a good step in the right direction of solving

It doesn't work as expected.

The simplest solution would be to always prefix a language code to the absolute paths of non-en section pages, that causes problems for our link checker, which requires the use of canonical links (in other words, it knows nothing and can't deal with redirects). I'll post more later.

@chalin chalin added bug Something isn't working p1-high i18n internationalization labels Nov 7, 2024
@chalin chalin self-assigned this Nov 7, 2024
@chalin chalin added the CI/infra CI & infrastructure label Nov 7, 2024
@chalin chalin changed the title Render-link hook isn't working as expected Render-link hook isn't generating locale specific paths when possible Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/infra CI & infrastructure i18n internationalization p1-high
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant