-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add what is opentelemetry page in french #5408
Add what is opentelemetry page in french #5408
Conversation
bbaec77
to
a4a1d50
Compare
@open-telemetry/docs-fr-approvers @iguitton, @pierrehilbert PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestions.
Also, I would choose between adding dots or not at the end of every bullet points to be consistent.
I didn't add them because that's what English is doing. But some may have slipped. |
Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
41ddc60
to
0312201
Compare
I think you should remove the |
I'd like to follow the process and stick with the expectations for membership from our guidelines. This means you would need ~5 PRs to be written or reviewed to request membership. The exact number depends on the complexity of the different PRs you helped with. So what we will do until then is counting your textual reviewes ("lgtm", "looks good to me") as if you have approver status. Just tag me or @open-telemetry/docs-maintainers and one of us can help you with that. |
Co-authored-by: Pierre HILBERT <[email protected]>
No description provided.