Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add what is opentelemetry page in french #5408

Merged
merged 12 commits into from
Oct 16, 2024

Conversation

dmathieu
Copy link
Member

No description provided.

@dmathieu dmathieu force-pushed the fr-what-is-opentelemetry branch 4 times, most recently from bbaec77 to a4a1d50 Compare October 15, 2024 12:07
@dmathieu dmathieu marked this pull request as ready for review October 15, 2024 12:12
@dmathieu dmathieu requested a review from a team as a code owner October 15, 2024 12:12
@opentelemetrybot opentelemetrybot requested review from a team October 15, 2024 17:39
@svrnm
Copy link
Member

svrnm commented Oct 16, 2024

@open-telemetry/docs-fr-approvers @iguitton, @pierrehilbert PTAL!

Copy link
Contributor

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions.
Also, I would choose between adding dots or not at the end of every bullet points to be consistent.

content/fr/docs/what-is-opentelemetry.md Show resolved Hide resolved
content/fr/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
content/fr/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
content/fr/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
content/fr/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
content/fr/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
content/fr/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
content/fr/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
@dmathieu
Copy link
Member Author

Also, I would choose between adding dots or not at the end of every bullet points to be consistent.

I didn't add them because that's what English is doing. But some may have slipped.

@dmathieu dmathieu removed request for a team October 16, 2024 07:58
@pierrehilbert
Copy link
Contributor

I think you should remove the lang:pt from this PR to avoid confusion.
I can't approve the PR but looks great to me, thanks for taking into account my suggestions.
@svrnm Should I follow this process by adding both you and @dmathieu to be able to approve this kind of PRs?

@svrnm
Copy link
Member

svrnm commented Oct 16, 2024

I think you should remove the lang:pt from this PR to avoid confusion. I can't approve the PR but looks great to me, thanks for taking into account my suggestions. @svrnm Should I follow this process by adding both you and @dmathieu to be able to approve this kind of PRs?

I'd like to follow the process and stick with the expectations for membership from our guidelines. This means you would need ~5 PRs to be written or reviewed to request membership. The exact number depends on the complexity of the different PRs you helped with.

So what we will do until then is counting your textual reviewes ("lgtm", "looks good to me") as if you have approver status. Just tag me or @open-telemetry/docs-maintainers and one of us can help you with that.

@svrnm svrnm added this pull request to the merge queue Oct 16, 2024
Merged via the queue into open-telemetry:main with commit f9382f7 Oct 16, 2024
17 checks passed
@dmathieu dmathieu deleted the fr-what-is-opentelemetry branch October 16, 2024 09:33
olamideTiana pushed a commit to olamideTiana/opentelemetry.io that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants