Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add qoutation marks around bash variables #5377

Conversation

FatumaA
Copy link

@FatumaA FatumaA commented Oct 10, 2024

Added quotation marks around variables.
Builds but leaves lots of warnings:
Edit: The warnings were not there before I added the quotes

WARN  docs/specs/otel/common/_index.md: use a local path, not an external URL, for the following reference to a local specification page: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attribute-naming.md
WARN  docs/specs/otel/common/_index.md: use a local path, not an external URL, for the following reference to a local specification page: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attribute-requirement-level.md
WARN  docs/specs/otel/common/attribute-naming.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/docs/specs/semconv/general/attribute-naming/
WARN  docs/specs/otel/common/attribute-requirement-level.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/

Fixes #5359

@FatumaA FatumaA requested a review from a team as a code owner October 10, 2024 15:06
Copy link

linux-foundation-easycla bot commented Oct 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: FatumaA / name: Fatuma Abdullahi (ed1d49b)

@svrnm
Copy link
Member

svrnm commented Oct 10, 2024

those issues are probably unrelated.

@chalin PTAL, I think that looks good, but since you wrote most of the script I would like to get your review as well

@chalin chalin force-pushed the fix-update-script-to-handle-folder-spaces branch from f6c8da2 to ed1d49b Compare October 16, 2024 19:49
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FatumaA. Thanks for this attempt at a fix, but this breaks the build rather than fixing it. As you've noted already, the warnings (which are a symptom of the build not working), were not there before. https://github.com/open-telemetry/opentelemetry.io/actions/runs/11372802351/job/31638107804?pr=5377

Let me take a look at a fix and report back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build fails when within a folder with spaces
3 participants