Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails when within a folder with spaces #5359

Closed
FatumaA opened this issue Oct 9, 2024 · 4 comments · Fixed by #5422
Closed

Build fails when within a folder with spaces #5359

FatumaA opened this issue Oct 9, 2024 · 4 comments · Fixed by #5422
Labels
bug Something isn't working

Comments

@FatumaA
Copy link

FatumaA commented Oct 9, 2024

What needs to be changed?
Add a note that npm run build will fail if the cloned repo is within a folder that has spaces

What is the name + path of the page that needs changed?
content/en/docs/contributing/development.md

Additional context:
This might only be an issue if you run the build command within a terminal that you've changed to (cd into). That is, if you are within the parent folder and you cd'd into the repo via the terminal then run npm run build from there.

@FatumaA FatumaA added the bug Something isn't working label Oct 9, 2024
@svrnm
Copy link
Member

svrnm commented Oct 9, 2024

thanks for reporting, I can reproduce that error on MacOS as well. Root cause for this issue is at the top of https://github.com/open-telemetry/opentelemetry.io/blob/main/scripts/content-modules/cp-pages.sh, because the space in the dir name leads to the following problems:

> cp:spec
> scripts/content-modules/cp-pages.sh

scripts/content-modules/cp-pages.sh: line 4: cd: too many arguments
scripts/content-modules/cp-pages.sh: line 22: /Users/neumanns/Folder: No such file or directory
OTEL SPEC pages: copied and processed
scripts/content-modules/cp-pages.sh: line 41: /Users/neumanns/Folder: No such file or directory
OTLP SPEC pages: copied and processed
OTLP SPEC protos copied and processed
scripts/content-modules/cp-pages.sh: line 68: /Users/neumanns/Folder: No such file or directory
COMMUNITY pages: copied and processed
scripts/content-modules/cp-pages.sh: line 86: /Users/neumanns/Folder: No such file or directory
SEM CONV  pages: copied and processed
scripts/content-modules/cp-pages.sh: line 103: /Users/neumanns/Folder: No such file or directory
OpAMP SPEC page: copied and processed

@FatumaA
Copy link
Author

FatumaA commented Oct 9, 2024

In that case, a fix there would make more sense than adding the note.

Is that something I can attempt as I wait for the official Outreachy issue?

@svrnm
Copy link
Member

svrnm commented Oct 10, 2024

In that case, a fix there would make more sense than adding the note.

Is that something I can attempt as I wait for the official Outreachy issue?

If you know how to fix a shell script by applying proper escaping&quoting yes, you can give it a try!

@FatumaA
Copy link
Author

FatumaA commented Oct 10, 2024

In that case, a fix there would make more sense than adding the note.
Is that something I can attempt as I wait for the official Outreachy issue?

If you know how to fix a shell script by applying proper escaping&quoting yes, you can give it a try!

Not really but I attempted regardless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants