Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java sampling documentation page #4736

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

jaydeluca
Copy link
Member

Contributes to #2548

Follows up on a few comments in #4199

What I added/changed:

  • Documented the ability to configure with environment variables in a top-level section in this guide, added link to configuration page with all options.
  • Added a note above the custom code section about other ways of sampling (agent, spring starter etc)
  • Emphasized that most the defaults suffice for most users, and that most users don't need to customize the sampler.
  • Removed the production guidance at the bottom of the page - there seemed to be some pushback in the original PR and I also didn't find the recommendation to be very clear. I can add back in or update if needed.
  • Added some more context about the different sampler types
  • Tried to follow similar layouts and content as other languages, but there isn't a whole lot of consistency.

@jaydeluca jaydeluca requested review from a team June 24, 2024 12:10
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of suggestions.

+CC @open-telemetry/java-maintainers Please have a look.

content/en/docs/languages/java/sampling.md Outdated Show resolved Hide resolved
content/en/docs/languages/java/sampling.md Outdated Show resolved Hide resolved
@cartermp cartermp added the sig-approval-missing Co-owning SIG didn't provide an approval label Jun 24, 2024
@cartermp
Copy link
Contributor

cartermp commented Jul 3, 2024

@open-telemetry/java-approvers please take a look!

1 similar comment
@svrnm
Copy link
Member

svrnm commented Jul 9, 2024

@open-telemetry/java-approvers please take a look!

@svrnm svrnm merged commit 3c8debc into open-telemetry:main Jul 25, 2024
17 checks passed
@svrnm
Copy link
Member

svrnm commented Jul 25, 2024

@jaydeluca thank you for your continued contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig:java sig-approval-missing Co-owning SIG didn't provide an approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants