Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Meta] Sampling #2548

Closed
4 of 11 tasks
svrnm opened this issue Mar 28, 2023 · 4 comments
Closed
4 of 11 tasks

[Meta] Sampling #2548

svrnm opened this issue Mar 28, 2023 · 4 comments
Labels
0-meta enhancement New feature or request help wanted Extra attention is needed sig:cpp sig:dotnet sig:java sig:php sig:python sig:rust sig:swift

Comments

@svrnm
Copy link
Member

svrnm commented Mar 28, 2023 •
edited
Loading

Add basic documentation for all languages about Sampling:

Note

To implement this for a new language, please take a documentation from an existing language (https://opentelemetry.io/docs/instrumentation/go/sampling/ or https://opentelemetry.io/docs/instrumentation/js/sampling/) and adjust it for the language you picked
@svrnm svrnm added the 0-meta label Apr 24, 2023
@svrnm svrnm changed the title Sampling Meta Issue [Meta] Sampling Apr 24, 2023
@mahitha00
Copy link

is issue still open

@svrnm
Copy link
Member Author

svrnm commented Jan 19, 2024

is issue still open

yes, this still needs to be resolved for some of the languages.

@konstantinoskolios konstantinoskolios mentioned this issue Mar 24, 2024
Merged
@konstantinoskolios
Copy link
Contributor

Hello @svrnm,

I hope you're doing well! I've just made my first contribution by opening PR #4199 . Whenever you find a moment, could you kindly review it?

Thank you so much for your time and assistance!

@svrnm
Copy link
Member Author

svrnm commented Mar 26, 2024

I hope you're doing well! I've just made my first contribution by opening PR #4199 . Whenever you find a moment, could you kindly review it?

Thank you. Looks like @cartermp already took a look :-)

@jaydeluca jaydeluca mentioned this issue Jun 24, 2024
Merged
@svrnm svrnm removed the good first issue Good for newcomers label Oct 3, 2024
@svrnm svrnm closed this as completed Nov 26, 2024
@svrnm svrnm reopened this Nov 26, 2024
@svrnm svrnm closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0-meta enhancement New feature or request help wanted Extra attention is needed sig:cpp sig:dotnet sig:java sig:php sig:python sig:rust sig:swift
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@svrnm @konstantinoskolios @mahitha00