fix java redirects #4562
fix java redirects #4562
Conversation
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| title: Out of the box instrumentation | |||
| description: Out of the box instrumentation for the starter | |||
| aliases: [../annotations] | |||
| aliases: [../instrumentation] | |||
There was a problem hiding this comment.
do we want the alias to stay under /spring-boot-starter/*, e.g.
| aliases: [../instrumentation] | |
| aliases: [instrumentation] |
There was a problem hiding this comment.
That alias shouldn't be there in the first place. It's been dropped in #4563.
|
@open-telemetry/docs-approvers et al: I think that we need to fine tune our PR review and merging process. I wasn't done reviewing #4554, and that PR wasn't ready to be merged IMHO. In particular (as some of you have noted) because more aliases were needed. I didn't comment on the need for aliases on my first review pass because in my first review pass I suggested some structural changes -- so it didn't make sense to suggest specific aliases until the section structure stabilized. Any suggestions on how to improve our process? Maybe if on @open-telemetry/docs-approvers makes some suggested changes, wait for them (a reasonable amount of time) to give a final approval? No big deal, and I'm really just hoping to make our contribution approval process smoother. Lemme know what y'all think. |
|
I would propose some kind of disclaimer if reviews are being done in stages. FWIW my general philosophy for this kind of stuff is to bias towards merging when content looks good and keep the flow of PRs going, but I missed that this re-org of pages would need redirects put into place as well. |
There was a problem hiding this comment.
Thanks for this PR @zeitlinger. I've submitted an alternative (simpler) fix, see #4563 -- by adding a single extra alias we can address the broken-link issue you faced, without having to introduce a wildcard redirect rule. Also #4563 drops some unnecessary aliases and includes some preliminary copyedits.
All: PTAL at #4563.
thanks @chalin - much simpler than my fix! |
No description provided.