-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Spring Boot content #4554
Reorganize Spring Boot content #4554
Conversation
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9283220758 |
e4df8ec
to
423e491
Compare
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9283588290 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the page org isn't quite working -- e.g., if there's a starter
section then it needs an index page. But before making that change, consider this question: will there ever be content under content/en/docs/zero-code/java/spring-boot
other than for the SB Starter? If not, how about renaming the folder to content/en/docs/zero-code/java/spring-boot-start
.
Even if there is, maybe what we want is:
docs/zero-code/java
- agent
- spring-boot
- spring-boot-starter
I recall that we had started discussing such options elsewhere. I guess that now's the time to come to a consensus.
@jeanbisutti - please resolve conflicts by rebasing. |
ecf8c0e
to
056fd13
Compare
I have rebased.
I don't think we will have content under content/en/docs/zero-code/java/spring-boot other than for the Spring Boot starter. So, I agree to rename the folder, which would reflect the new menu content: The new folder name would be content/en/docs/zero-code/java/spring-boot-start or content/en/docs/zero-code/java/spring-boot-starter? @zeitlinger @svrnm WDYT? |
/docs/zero-code/java/spring-boot-start/getting-started/ or /docs/zero-code/java/spring-boot-starter/getting-started/ sounds good |
content/en/docs/zero-code/java/spring-boot/starter/agent-vs-starter.md
Outdated
Show resolved
Hide resolved
content/en/docs/zero-code/java/spring-boot/starter/getting-started.md
Outdated
Show resolved
Hide resolved
content/en/docs/zero-code/java/spring-boot/starter/getting-started.md
Outdated
Show resolved
Hide resolved
content/en/docs/zero-code/java/spring-boot/starter/getting-started.md
Outdated
Show resolved
Hide resolved
content/en/docs/zero-code/java/spring-boot/starter/getting-started.md
Outdated
Show resolved
Hide resolved
content/en/docs/zero-code/java/spring-boot/starter/getting-started.md
Outdated
Show resolved
Hide resolved
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9287963651 |
…ing-page better spring boot landing page
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9302215115 |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9302399728 |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9303619607 |
Cross-reference to my comments about this PR: #4562 (comment). |
--- | ||
|
||
The OpenTelemetry Spring Boot starter provides of the box | ||
instrumentation](../out-of-the-box-instrumentation) that you can complete with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link syntax is invalid here.
--- | ||
title: Annotations | ||
description: Using instrumentation annotations with the Spring starter. | ||
aliases: [../annotations] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be this alias here.
--- | ||
title: Out of the box instrumentation | ||
description: Out of the box instrumentation for the starter | ||
aliases: [../annotations] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be this alias here either. I'm curious what you had in mind @jeanbisutti, what were you trying to acheive?
This PR reorganizes the Spring Boot content following the discussions in #4324.
Further improvements could certainly be made to the Spring Boot content. This PR focuses on the reorganization discussed in #4324.
Preview: https://deploy-preview-4554--opentelemetry.netlify.app/docs/zero-code/java/spring-boot-starter/
Fix #4324