Removes deprecated ErrNilNextConsumer and solves type error for typeStr #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarsojabbes
requested review from
a team and
Aneurysm9
and removed request for
a team
theletterf
approved these changes
Apr 8, 2024
mx-psi
reviewed
Apr 8, 2024
Comment on lines
400
to
403
| const ( | ||
| typeStr = "tailtracer" | ||
| var ( | ||
| typeStr = component.MustNewType("tailtracer") | ||
| defaultInterval = 1 * time.Minute | ||
| ) |
There was a problem hiding this comment.
nit: We could leave defaultInterval as const
There was a problem hiding this comment.
Fixed! Can you take a second look?
|
+1 this PR LGTM |
mx-psi
approved these changes
Apr 8, 2024
bryan-aguilar
approved these changes
Apr 8, 2024
cartermp
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects type error for typeStr on Custom Receiver documentation, as well as removes ErrNilNextConsumer checks.
As of version 0.97.0 for dependencies when creating a custom receiver, using typeStr directly as a string was throwing an error of
cannot use typeStr (variable of type string) as component.Type value in argument to receiver.NewFactorywhich should now be done usingcomponent.MustNewType("tailtracer"), in a var declaration.Also, as in Issue 9322 and later on accept as PR 9779 and PR 31793,
component.ErrNilNextConsumeris not a valid error type.