Remove checks of ErrNilNextConsumer #31793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
requested review from
jmacd,
dmitryax,
djaglowski,
jpkrohling and
Aneurysm9
as code owners
github-actions
bot
added
processor/tailsampling
github-actions
bot
requested review from
alexvanboxel,
boostchicken,
crobert-1,
gouthamve,
JaredTan95,
mar4uk,
mcardy,
moh-osman3,
pellared,
pxaws,
rmfitzpatrick,
srprash and
wangzlei
atoulme
force-pushed
the
remove_ErrNilNextConsumer_impl
branch
from
be9e5cb to
9a3ec60
Compare
dmitryax
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove explicit checks in all receivers to check if the next consumer is nil.
The nil check is now done by the pipeline builder.
This is a follow up of open-telemetry/opentelemetry-collector#9322.
This PR blocks open-telemetry/opentelemetry-collector#9779.