Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry .NET SDK to the registry. #4049

Merged

Conversation

jamescrosswell
Copy link
Contributor

No description provided.

@jamescrosswell jamescrosswell requested a review from a team February 26, 2024 06:50
Copy link

linux-foundation-easycla bot commented Feb 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@svrnm
Copy link
Member

svrnm commented Feb 26, 2024

please sign the CLA.

On the PR: We are currently moving vendor specific distributions over to https://opentelemetry.io/ecosystem/distributions/, I would recommend you raise a different PR that deletes all sentry entries in the registry and adds them to that page.

@svrnm svrnm added the CLA: no label Feb 26, 2024
@jamescrosswell
Copy link
Contributor Author

please sign the CLA.

On the PR: We are currently moving vendor specific distributions over to https://opentelemetry.io/ecosystem/distributions/, I would recommend you raise a different PR that deletes all sentry entries in the registry and adds them to that page.

OK. I'm a contractor for Sentry so I'll need to get @bitsandfoxes to track down the CLA manager for Sentry.

Thanks for the heads up re restructuring the docs. 👍🏻

@svrnm
Copy link
Member

svrnm commented Mar 1, 2024

@jamescrosswell can we close this PR or do you want to have this entry still added to the registry? If so we need you to sign the CLA first

@jamescrosswell
Copy link
Contributor Author

@jamescrosswell can we close this PR or do you want to have this entry still added to the registry? If so we need you to sign the CLA first

Hi @svrnm , I just signed the CLA... so yes, if we could please merge that would be great!

@svrnm svrnm removed the CLA: no label Mar 4, 2024
svrnm
svrnm previously requested changes Mar 4, 2024
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamescrosswell We can merge this in after the changes have been applied. Note that we need Sentry to take a look at this and migrate their registry entries over to the distribution page eventually.

data/registry/tools-dotnet-sentry.yml Outdated Show resolved Hide resolved
data/registry/tools-dotnet-sentry.yml Outdated Show resolved Hide resolved
@jamescrosswell
Copy link
Contributor Author

@jamescrosswell We can merge this in after the changes have been applied. Note that we need Sentry to take a look at this and migrate their registry entries over to the distribution page eventually.

Understood. @bitsandfoxes do you want to tap someone on the shoulder in the office about this?

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience in getting this one in!

@cartermp cartermp merged commit 454b249 into open-telemetry:main Mar 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants