Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve dotnet getting started instructions #3661

Merged
merged 2 commits into from
Dec 8, 2023
Merged

improve dotnet getting started instructions #3661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b83cc
add missing usings and RollDice function
andrew-hillier Dec 8, 2023
f64256b
use shared instance of random
andrew-hillier Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions content/en/docs/instrumentation/net/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ code:
```csharp
using System.Globalization;

using Microsoft.AspNetCore.Mvc;

var builder = WebApplication.CreateBuilder(args);
var app = builder.Build();

Expand All @@ -65,6 +67,11 @@ string HandleRollDice([FromServices]ILogger<Program> logger, string? player)
return result.ToString(CultureInfo.InvariantCulture);
}

int RollDice()
{
return Random.Shared.Next(1, 7);
}

app.MapGet("/rolldice/{player?}", HandleRollDice);

app.Run();
Expand Down Expand Up @@ -114,7 +121,21 @@ that will generate the telemetry, and set them up.

2. Setup the OpenTelemetry code

In Program.cs, replace the following lines:

```csharp
var builder = WebApplication.CreateBuilder(args);
var app = builder.Build();
```

With:

```csharp
using OpenTelemetry.Logs;
using OpenTelemetry.Metrics;
using OpenTelemetry.Resources;
using OpenTelemetry.Trace;

var builder = WebApplication.CreateBuilder(args);

const string serviceName = "roll-dice";
Expand Down