Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve dotnet getting started instructions #3661

Merged
merged 2 commits into from
Dec 8, 2023
Merged

improve dotnet getting started instructions #3661

merged 2 commits into from
Dec 8, 2023

Conversation

andrew-hillier
Copy link
Contributor

  • on the initial instructions, added a function for RollDice() that was referenced, but not included.
  • when adding the Open Telemetry code, instructions to replace certain lines of code, including the required using statements.

@andrew-hillier andrew-hillier requested review from a team December 8, 2023 14:11
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 8, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@cartermp
Copy link
Contributor

cartermp commented Dec 8, 2023

@andrew-hillier can you sign the CLA? Then we can review

cartermp
cartermp approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think some of this got lost in a transition from a previous version of this doc. Thanks for correcting it!

@andrew-hillier
Copy link
Contributor Author

Thank you, I think some of this got lost in a transition from a previous version of this doc. Thanks for correcting it!

No problem, happy to contribute! 😀

@cartermp cartermp merged commit 0000a92 into open-telemetry:main Dec 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@reyang reyang reyang approved these changes

@pjanotti pjanotti pjanotti approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrew-hillier @cartermp @cijothomas @pjanotti @reyang