-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the java exporters page #3558
Conversation
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a read-through. Looks good from here. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few comments but looks pretty good. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending feedback addressed from @jack-berg
@jack-berg / @open-telemetry/java-approvers PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with the recommendations from @svrnm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we generally recommend using the autoconfigure API, do you think that could work on this page? (i'm also totally good with this PR as-is and we can always explore converting it to autoconfigure API later)
Co-authored-by: Trask Stalnaker <[email protected]>
I would say so, yes. For Node.JS we finally also agreed that we do not provide that many instructions for the "low level" API but using NodeSDK with all the automatic wiring. @open-telemetry/docs-approvers WDYT? |
Signed-off-by: svrnm <[email protected]>
Based on #3355 I updated the java exporters documentation to have a similar structure.