Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java Exporter Pages to use autoconfigure #3608

Closed
svrnm opened this issue Nov 27, 2023 · 12 comments
Closed

Update Java Exporter Pages to use autoconfigure #3608

svrnm opened this issue Nov 27, 2023 · 12 comments
Labels
help wanted Extra attention is needed sig:java

Comments

@svrnm
Copy link
Member

svrnm commented Nov 27, 2023

Via #3558 (review)

Java pages about Exporters need to be updated to make use of autoconfigure

@svrnm svrnm added help wanted Extra attention is needed sig:java labels Nov 27, 2023
@MeenuyD
Copy link

MeenuyD commented Nov 28, 2023

Hello @svrnm I would like to work on this issue can you please assign me and guide how changes to be done?

@svrnm
Copy link
Member Author

svrnm commented Nov 28, 2023

@MeenuyD we do not assign issues (see our guidelines on this topic), but it is noted that you want to take a look into it and provide a PR.

What needs to be changed:

  • Take a look at how manual instrumentation is making use of auto configure: https://opentelemetry.io/docs/instrumentation/java/manual/#automatic-configuration, the exporter docs should built on top of that
  • The structure of the document should remain, since we aim for consistency across languages
  • You can provide updates incrementally, e.g. start with OTLP (or any other of the listed exporters) and provide a PR, after merging, the same should be replicatable for other exporters as well

@open-telemetry/java-approvers any additional comments?

@MeenuyD
Copy link

MeenuyD commented Nov 28, 2023

Ok

@nerudadhich
Copy link
Contributor

Hi @MeenuyD 👋 , Have you started working on this, Do you need any help or anything let me know.

@nerudadhich
Copy link
Contributor

Hi @svrnm , I have started working on this. Will let you know once it's ready for review.

@svrnm
Copy link
Member Author

svrnm commented Mar 26, 2024

Thank you!

@theletterf
Copy link
Member

@nerudadhich Any update?

@nerudadhich
Copy link
Contributor

nerudadhich commented Apr 9, 2024

Hi @theletterf . I have amended the details, But wondering if we should add gradle config as well as RollController instead of referring to dice app example links ?

PR - #4194

What do you think ?

@svrnm
Copy link
Member Author

svrnm commented Apr 10, 2024

But wondering if we should add gradle config as well as RollController instead of referring to dice app example links ?

that's probably a question for the ongoing PR and @open-telemetry/java-approvers

@trask
Copy link
Member

trask commented Apr 11, 2024

But wondering if we should add gradle config as well as RollController instead of referring to dice app example links ?

hi @nerudadhich!

I see gradle config here already: https://opentelemetry.io/docs/languages/java/exporters/#otlp-dependencies

or are you referring to another place?

RollController instead of referring to dice app example links

i'm not sure what you mean here, can you explain a bit more? thanks

@nerudadhich
Copy link
Contributor

Hi @trask Could you please check the PR here and the Preview here

I have added all the details (Working sample app code) explicitly instead of referring to example link.
I hope this make sense to you ?

@svrnm
Copy link
Member Author

svrnm commented Nov 26, 2024

we refactored the java docs, so this issue might longer be applicable

@svrnm svrnm closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed sig:java
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants