Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing cspell:ignore to registry entries #3376

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add missing cspell:ignore to registry entries #3376

merged 1 commit into from
Oct 16, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Oct 13, 2023

No description provided.

@svrnm svrnm requested a review from a team October 13, 2023 07:57
svrnm added a commit that referenced this pull request Oct 16, 2023
@svrnm
Update check-spelling.yml
094f47b 
#3292 allows us to also apply cspell checks on the registry files.

See #3376 for newly introduced cspell issues.
@svrnm svrnm mentioned this pull request Oct 16, 2023
Merged
@chalin chalin force-pushed the fix-registry-entries branch from 7be2997 to 12b5d60 Compare October 16, 2023 15:41
chalin
chalin approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, was hitting these locally.

data/registry/instrumentation-python-openai.yml
@@ -1,3 +1,4 @@
# cSpell:ignore openai
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote to add this one globally. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it like that for now, if we have it more often then we can move it out.

@chalin
Copy link
Contributor

chalin commented Oct 16, 2023

@svrnm - is this the followup to #3292, or is there more?

@svrnm
Copy link
Member Author

svrnm commented Oct 16, 2023

@svrnm - is this the followup to #3292, or is there more?

there should only be this one so far.

@chalin chalin merged commit 713b4dd into open-telemetry:main Oct 16, 2023
chalin pushed a commit that referenced this pull request Oct 16, 2023
@svrnm @chalin
Update check-spelling.yml
4becbad 
#3292 allows us to also apply cspell checks on the registry files.

See #3376 for newly introduced cspell issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svrnm @chalin